Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Laravel 9.x Shift #96

Merged
merged 22 commits into from
Sep 21, 2024
Merged

Laravel 9.x Shift #96

merged 22 commits into from
Sep 21, 2024

Conversation

simonostendorf
Copy link
Contributor

This pull request includes the changes for upgrading to Laravel 9.x. Feel free to commit any additional changes to the shift-129283 branch.

Before merging, you need to:

  • Checkout the shift-129283 branch
  • Review all pull request comments for additional changes
  • Run composer update (if the scripts fail, try with --no-scripts)
  • Clear any config, route, or view cache
  • Thoroughly test your application (no tests?, no CI?)

If you need help with your upgrade, check out the Human Shifts.

@laravel-shift
Apply Laravel coding style
d96dfd7 
Shift automatically applies the Laravel coding style - which uses the PSR-12 coding style as a base with some minor additions.

You may customize the code style applied by configuring [Pint](https://laravel.com/docs/pint), [PHP CS Fixer](https://github.com/FriendsOfPHP/PHP-CS-Fixer), or [PHP CodeSniffer](https://github.com/squizlabs/PHP_CodeSniffer) for your project root.

For more information on customizing the code style applied by Shift, [watch this short video](https://laravelshift.com/videos/shift-code-style).
@laravel-shift
Move resources/lang folder
261fb1e
@laravel-shift
Shift registered middleware
766df9d
@laravel-shift
Remove fruitcake/laravel-cors dependency
5925007
@laravel-shift
Streamline $commands property
020b222
@laravel-shift
Replace deprecated HEADER_X_FORWARDED_ALL constant
674575d
@laravel-shift
Upgrade to Flysystem 3.0
77a3d3c
@laravel-shift
Shift core files
a027f91
@laravel-shift
Convert route options to fluent methods
f328e59 
Laravel 8 adopts the tuple syntax for controller actions. Since the old options array is incompatible with this syntax, Shift converted them to use modern, fluent methods.
@laravel-shift
Adopt class based routes
12d71df
@laravel-shift
Shift config files
66de806
@laravel-shift
Default config files
71c367d 
In an effort to make upgrading the constantly changing config files easier, Shift defaulted them and merged your true customizations - where ENV variables may not be used.
@laravel-shift
Bump Composer dependencies
80579e9
@laravel-shift
Use <env> tags for configuration
b65c8ef 
`<env>` tags have a lower precedence than system environment variables making it easier to overwrite PHPUnit configuration values in additional environments, such a CI.

Review this blog post for more details on configuration precedence when testing Laravel: https://jasonmccreary.me/articles/laravel-testing-configuration-precedence/
@laravel-shift
Adopt anonymous migrations
51fa7b7
@laravel-shift
Add migration for Sanctum 3.0
577623a
@simonostendorf
Copy link
Contributor Author

ℹ️ Laravel 9 moved the resources/lang folder to the top level of the project. While Shift automated this change, you may have additional references to the previous folder which need to be updated.

@simonostendorf
Copy link
Contributor Author

⚠️ Laravel 9 upgraded to Flysystem 3.0 causing the behavior of the Storage facade to change slightly:

  • Write operations (such as put and write) now overwrite existing files by default and return false instead of throwing an exception.
  • Read operations (such as get and download) now return null instead of a FileNotFoundException when a file is missing.
  • The delete operation now returns true even if the file did not exist.

For more details, you may review the Flysystem 3.x section of the Upgrade Guide.

@simonostendorf
Copy link
Contributor Author

⚠️ Laravel 9 transitioned from SwiftMailer to Symfony Mailer. While this transition should be relatively seamless and Shift automates any tedious changes, some changes may not reliably be automated.

Dependencies
Some mail providers may require an additional dependency. For example, if you are using Mailgun, then you will need to install the symfony/mailgun-mailer package:

composer require symfony/mailgun-mailer symfony/http-client

For more details on what has changed you may review the Symfony Mailer section of the Upgrade Guide.

@simonostendorf
Copy link
Contributor Author

⚠️ The public/web.config file has been removed from new Laravel projects. The presence of this file creates a potential security risk for projects not using Microsoft IIS as their web server.

Shift detected this file was modified and did not remove it. Unless you are using Microsoft IIS as your web server, you should remove this file.

@simonostendorf
Copy link
Contributor Author

⚠️ The FILESYSTEM_DRIVER environment variable was renamed to FILESYSTEM_DISK in Laravel 9. Shift attempted to automate this change, but you should review any additional environment configuration and rename this variable.

@simonostendorf
Copy link
Contributor Author

⚠️ Shift upgraded your configuration files by defaulting them and merging your true customizations. These include values which are not changeable through core ENV variables.

You should review this commit for additional customizations or opportunities to use new ENV variables. If you have a lot of customizations, you may undo this commit with git revert 71c367dc and make the config file changes manually.

@simonostendorf
Copy link
Contributor Author

ℹ️ The FILESYSTEM_CLOUD environment variable was removed in a later release of Laravel 8. While you may still use the cloud disk, you are encouraged to configure your own disks.

@simonostendorf
Copy link
Contributor Author

⚠️ The token driver for API authentication is no longer available. This driver was not very robust and was removed from the documentation. Laravel now recommends using Sanctum.

If you were using the token driver, you may re-add it within your auth.php configuration file then migrate to Sanctum at your convenience.

@simonostendorf
Copy link
Contributor Author

ℹ️ Shift updated your dependencies for Laravel 9. While many of the popular packages are reviewed, you may have to update additional packages in order for your application to be compatible with Laravel 9. Watch dealing with dependencies for tips on handling any Composer issues.

@simonostendorf
Copy link
Contributor Author

ℹ️ Laravel 9 adopted anonymous migrations. Shift automated this change to align with modern Laravel conventions and avoid naming migrations.

@simonostendorf
Copy link
Contributor Author

ℹ️ Sanctum 3.x added an expires_at column to support expiring tokens. Shift detected you have a migration for this table and created a migration for this new column. Be sure to run php artisan migrate to complete your upgrade.

@simonostendorf
Copy link
Contributor Author

⚠️ Shift detected you are running Laravel Sail. If you have not customized your stack, you may run php artisan sail:install to regenerate the latest docker-compose.yml. Otherwise, you should ensure your stack is running PHP 8.0 or higher.

@simonostendorf
Copy link
Contributor Author

ℹ️ All of the underlying Symfony components used by Laravel have been upgraded to Symfony 6. If you are directly interacting with any Symfony component, you should review the Symfony change log for additional changes.

@simonostendorf
Copy link
Contributor Author

ℹ️ Laravel 9 now uses Vite to build frontend assets. While you may continue to use Laravel Mix, it is no longer the default. If you wish to modernize your application to use Vite, you may run the Vite Converter for free.

@simonostendorf
Copy link
Contributor Author

⚠️ Laravel 9.x has reached end of life. It no longer receives bug fixes or security updates. Shift recommends continuing to upgrade to the latest version (Laravel 11.x).

@simonostendorf
Copy link
Contributor Author

also do npm dependency update

@simonostendorf simonostendorf added this to the 3.0.0 milestone Sep 21, 2024
@simonostendorf simonostendorf merged commit 7cd3c88 into dev Sep 21, 2024
1 check passed
@simonostendorf simonostendorf deleted the shift-129283 branch September 21, 2024 11:49
This was linked to issues Oct 6, 2024
Update frontend dependencies #26
Closed
Update backend dependencies #27
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpih jpih jpih approved these changes

Assignees

@jpih jpih

@simonostendorf simonostendorf

Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

Update backend dependencies Update frontend dependencies
3 participants
@simonostendorf @jpih @laravel-shift